Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-09 Thread Laszlo Ersek
Wang, Jian J >> Sent: Thursday, November 9, 2017 8:42 AM >> To: Laszlo Ersek ; edk2-devel@lists.01.org >> Cc: Yao, Jiewen ; Dong, Eric >> Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of >> RT_CODE in memory map >> >> Hi Laszlo, >>

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Wang, Jian J
vel@lists.01.org > > Cc: Yao, Jiewen ; Dong, Eric > > Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > > RT_CODE in memory map > > > > Hi Laszlo, > > > > The memory range is FED0 - FED003FF. Actuall

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Yao, Jiewen
Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: Wednesday, November 08, 2017 10:17 PM > > To: Wang, Jian J ; edk2-devel@lists.01.org > > Cc: Yao, Jiewen ; Dong, Eric > > Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Wang, Jian J
2017 10:17 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > On 11/08/17 01:10, Wang, Jian J wrote: > > Hi Laszlo, > > > &

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Laszlo Ersek
ic >> Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of >> RT_CODE in memory map >> >> sorry about the late response >> >> On 11/03/17 01:57, Jian J Wang wrote: >>>> v2 >>>> a. Fix an issue which will cause setting capabil

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Laszlo Ersek
ssage- > From: Wang, Jian J > Sent: Tuesday, November 7, 2017 8:55 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric > Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > Thank

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-08 Thread Wang, Jian J
ists.01.org > > Cc: Yao, Jiewen ; Dong, Eric > > Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > > RT_CODE in memory map > > > > sorry about the late response > > > > On 11/03/17 01:57, Jian J Wang wrote: > > >> v2

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-07 Thread Wang, Jian J
code. > > Thanks/Ray > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Jian J Wang > > Sent: Friday, November 3, 2017 8:57 AM > > To: edk2-devel@lists.01.org > > Cc: Laszlo Ersek ; Yao, Ji

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-07 Thread Ni, Ruiyu
@lists.01.org] On Behalf Of > Jian J Wang > Sent: Friday, November 3, 2017 8:57 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric > Subject: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > > v2

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-07 Thread Zeng, Star
7 5:16 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Yao, Jiewen > ; Dong, Eric ; Zeng, Star > > Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries > of RT_CODE in memory map > > I am ok to this code approach. > > Ackno

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-07 Thread Wang, Jian J
Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 08, 2017 1:14 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple en

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-07 Thread Laszlo Ersek
sorry about the late response On 11/03/17 01:57, Jian J Wang wrote: >> v2 >> a. Fix an issue which will cause setting capability failure if size is >> smaller >>than a page. > > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-06 Thread Zeng, Star
, Eric Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map Thanks for the review. And I agree that GCD.SetMemoryAttributes should be used all the time in DxeCore. Let's fix it in another patch. > -Original Message- > From: Zeng,

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-06 Thread Wang, Jian J
: Laszlo Ersek ; Yao, Jiewen ; > Dong, Eric ; Zeng, Star > Subject: RE: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of > RT_CODE in memory map > > I am ok to this code approach. > > Acknowledged-by: Star Zeng > > Besides, I think except GCD services, DxeCo

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-06 Thread Zeng, Star
Cc: Laszlo Ersek ; Yao, Jiewen ; Dong, Eric Subject: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map > v2 > a. Fix an issue which will cause setting capability failure if size is smaller >than a page. More than one entry of RT_CODE memory might ca

[edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-11-02 Thread Jian J Wang
> v2 > a. Fix an issue which will cause setting capability failure if size is smaller >than a page. More than one entry of RT_CODE memory might cause boot problem for some old OSs. This patch will fix this issue to keep OS compatibility as much as possible. More detailed information, please r

[edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

2017-10-25 Thread Jian J Wang
> v2 just updated the commit message. Multiple RT_CODE in memory map was introduced by previous commit c1cab54ce57c2608b8b3ea051c7041f036f21153 This commit changed memory capability only based on page type of memory attributes. EDK2's report of memory map to OS is grouped by memory capabilit