Re: [edk2] [PATCH v2 1/2] ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl.

2018-02-07 Thread Gary Lin
On Wed, Feb 07, 2018 at 11:44:34PM +0100, Laszlo Ersek wrote: > "Compress.h" declares the Compress() function as EFIAPI, but the > definition in "Compress.c" lacks EFIAPI. > > GCC toolchains without LTO do not catch this error because "Compress.c" > does not include "Compress.h"; i.e. the declarat

[edk2] [PATCH v2 1/2] ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with decl.

2018-02-07 Thread Laszlo Ersek
"Compress.h" declares the Compress() function as EFIAPI, but the definition in "Compress.c" lacks EFIAPI. GCC toolchains without LTO do not catch this error because "Compress.c" does not include "Compress.h"; i.e. the declaration used by callers such as "EfiCompress.c" is not actually matched agai