Reviewed-by: Eric Dong
-Original Message-
From: Wang, Jian J
Sent: Thursday, June 14, 2018 8:47 AM
To: Laszlo Ersek ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong,
Eric
Subject: RE: [edk2] [PATCH v2 1/2] UefiCpuPkg/CpuDxe: allow accessing (DXE)
page table in SMM mode
Hi Laszlo,
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, June 13, 2018 11:10 PM
> To: Wang, Jian J ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Yao, Jiewen ; Dong,
> Eric
> Subject: Re: [edk2] [PATCH v2 1/2] Uef
On 06/13/18 17:14, Andrew Fish wrote:
>
>
>> On Jun 12, 2018, at 10:35 PM, Jian J Wang wrote:
>>
>>> v2:
>>> a. add more specific explanations in commit message
>>> b. add more comments in code
>>> c. remove redundant logic in IsInSmm()
>>> d. fix a logic hole in GetCurrentPagingContext()
> On Jun 12, 2018, at 10:35 PM, Jian J Wang wrote:
>
>> v2:
>> a. add more specific explanations in commit message
>> b. add more comments in code
>> c. remove redundant logic in IsInSmm()
>> d. fix a logic hole in GetCurrentPagingContext()
>> e. replace meanless constant macro with
Hi Jian,
I have three comments:
On 06/13/18 07:35, Jian J Wang wrote:
>> v2:
>> a. add more specific explanations in commit message
>> b. add more comments in code
>> c. remove redundant logic in IsInSmm()
>> d. fix a logic hole in GetCurrentPagingContext()
>> e. replace meanless
> v2:
> a. add more specific explanations in commit message
> b. add more comments in code
> c. remove redundant logic in IsInSmm()
> d. fix a logic hole in GetCurrentPagingContext()
> e. replace meanless constant macro with meaning ones
The MdePkg/Library/SmmMemoryAllocationLib, used
6 matches
Mail list logo
