Re: [edk2] [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift

2017-09-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Thursday, September 21, 2017 2:46 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Shi, Steven ; >Kinney, Michael D ; Gao, Liming > >Subject: [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift > >REF:

[edk2] [PATCH v2 1/6] MdePkg/PrintLib: Fix possible negative value left shift

2017-09-20 Thread Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=702 Within function InternalPrintLibSPrintMarker(), possible left shift of a negative value is found in: "(*(ArgumentString + 1) << 8)" which involves undefined behavior. Since '*(ArgumentString + 1)' is of type CONST CHAR8 (signed), it will be