Re: [edk2] [PATCH v2 2/2] EmbeddedPkg/DwEmmc: Adjust FIFO threshold

2017-07-07 Thread Jun Nie
2017-07-06 23:22 GMT+08:00 Leif Lindholm : > On Wed, Jul 05, 2017 at 04:27:08PM +0800, Jun Nie wrote: >> Adjust FIFO threshold according to FIFO depth. Skip >> the adjustment if we do not have FIFO depth info. >> > > So, this is a big improvement in readability - but some

Re: [edk2] [PATCH v2 2/2] EmbeddedPkg/DwEmmc: Adjust FIFO threshold

2017-07-06 Thread Leif Lindholm
On Wed, Jul 05, 2017 at 04:27:08PM +0800, Jun Nie wrote: > Adjust FIFO threshold according to FIFO depth. Skip > the adjustment if we do not have FIFO depth info. > So, this is a big improvement in readability - but some of my generic style comments do not appear to have been addressed. >

[edk2] [PATCH v2 2/2] EmbeddedPkg/DwEmmc: Adjust FIFO threshold

2017-07-05 Thread Jun Nie
Adjust FIFO threshold according to FIFO depth. Skip the adjustment if we do not have FIFO depth info. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h | 6