Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-27 Thread Wang, Jian J
Thanks. Since there're just some minor changes, I'll not provide v3 patches and push the changes to master soon. Regards, Jian From: Dong, Eric Sent: Tuesday, August 28, 2018 9:15 AM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Ni, Ruiyu Subject: RE: [PATCH v2 2/4]

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-27 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wang, Jian J > Sent: Tuesday, August 21, 2018 11:05 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek ; Ni, > Ruiyu > Subject: [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single > step in #PF handler > > >

Re: [edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-21 Thread Laszlo Ersek
On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >>n/a > > Once the #PF handler has set the page to be 'present', there should > be a way to reset it to 'not-present'. 'TF' bit in EFLAGS can be used > for this purpose. 'TF' bit will be set in interrupted function context > so that it can

[edk2] [PATCH v2 2/4] UefiCpuPkg/CpuExceptionHandlerLib: Setup single step in #PF handler

2018-08-20 Thread Jian J Wang
> v2 changes: >n/a Once the #PF handler has set the page to be 'present', there should be a way to reset it to 'not-present'. 'TF' bit in EFLAGS can be used for this purpose. 'TF' bit will be set in interrupted function context so that it can be triggered once the cpu control returns back to