Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Brian J. Johnson
2016 10:59 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Hi Ruiyu, I had seen the other comments and I just needed more time to think about them :) Please see my comments below

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-29 Thread Ni, Ruiyu
, 2016 10:52 AM To: Heyi Guo ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: RE: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Heyi, I was not able to remove the blue bar in the beginning of every line if I embedded my reply. So I will directly

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Ard Biesheuvel
On 29 March 2016 at 08:26, Kinney, Michael D wrote: > Ard, > > Many handlers running at the same TPL are ok as long as each of the handlers > run for very short periods of time. Any event handlers that execute as > raised TPL for extended periods of time will impact other event handlers. > Tha

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Kinney, Michael D
yu ; edk2- > de...@lists.01.org; Tian, Feng ; Zeng, Star > > Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate > by serial > IO mode > > On 29 March 2016 at 06:09, Kinney, Michael D > wrote: > > Ard, > > > > What is the timer rat

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Ard Biesheuvel
un...@lists.01.org] On Behalf Of Heyi >> Guo >> Sent: Monday, March 28, 2016 8:06 PM >> To: Ard Biesheuvel ; Ni, Ruiyu >> >> Cc: edk2-devel@lists.01.org; Tian, Feng ; Zeng, Star >> >> Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Kinney, Michael D
01.org; Tian, Feng ; Zeng, Star > > Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate > by serial > IO mode > > > > On 03/25/2016 01:56 PM, Ard Biesheuvel wrote: > > On 25 March 2016 at 03:52, Ni, Ruiyu wrote: > >> Heyi, >

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-28 Thread Heyi Guo
pth change in timer call back to update the interval. Regards, Ray From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 10:59 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling ra

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ard Biesheuvel
t; > > Regards, > Ray > > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Thursday, March 24, 2016 10:59 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star > Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate > by

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ni, Ruiyu
Ray From: Heyi Guo [mailto:heyi@linaro.org] Sent: Thursday, March 24, 2016 10:59 PM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Hi Ruiyu, I had seen the other comments an

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Heyi Guo
3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode > >Hi Ruiyu, > >Many thanks for your review. > >For questions 2#, I tested equation #1 with copy-paste on serial >terminal, and found it still missing some characters when the FIFO was >almost full (i.e. near the

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-24 Thread Ni, Ruiyu
;Kinney, Michael D >Subject: Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate >by serial IO mode > >Hi Ruiyu, > >Many thanks for your review. > >For questions 2#, I tested equation #1 with copy-paste on serial >terminal, and found it still missing some c

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Heyi Guo
-devel-boun...@lists.01.org] On Behalf Of Heyi Guo Sent: Thursday, March 17, 2016 10:37 PM To: edk2-devel@lists.01.org Cc: Heyi Guo ; Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode Calculate serial input polling rate according to

Re: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-23 Thread Ni, Ruiyu
t: [edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by >serial IO mode > >Calculate serial input polling rate according to parameters from >serial IO mode as below, to fix potential input truncation with fixed >polling interval 0.02s. > >Polling interval (10

[edk2] [PATCH v2 3/3] MdeModulePkg/TerminalDxe: Set polling rate by serial IO mode

2016-03-20 Thread Heyi Guo
Calculate serial input polling rate according to parameters from serial IO mode as below, to fix potential input truncation with fixed polling interval 0.02s. Polling interval (100ns) = FifoDepth * (ParityBits + StopBits + DataBits) * 10,000,000 / BaudRate However, as UEFI events will probably de