Fine.
I just had the thought from my first view to the code.
When I saw the name AhciPuisEnable, I thought there should be AhciPuisDisable
as well, but I did not find it.
Then I must check the comments and function header to know the details.
Thanks,
Star
-Original Message-
From: Ni,
I see your point.
I prefer to use AhciPuisEnable().
The function name describe the purpose.
The function body explains the details.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, June 5, 2018 1:17 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chiu, Chasel ; Zeng
Yes, that is why I was saying to use AhciSetFeaturePuis as the function name.
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, June 5, 2018 11:41 AM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Chiu, Chasel
Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru: enable/
The Set Feature cmd is used to enable/disable PUIS.
Thanks/Ray
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, June 5, 2018 11:35 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chiu, Chasel ; Zeng, Star
> Subject: RE: [PATCH v2 3/4] MdeModulePkg/AtaAtapiPassThru:
> enable/di
Reviewed-by: Star Zeng
How about using function name AhciSetFeaturePuis instead of AhciPuisEnable as
the function is not just to enable Puis?
Thanks,
Star
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 4, 2018 3:04 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Chiu, Chasel
S
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
Cc: Chasel Chiu
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 48 ++
.../Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c| 19 -
.../Bus/Ata/AtaAtapiPassThru/AtaAt
6 matches
Mail list logo
