Re: [edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Heyi Guo
On 09/09/2015 09:38 PM, Ard Biesheuvel wrote: On 9 September 2015 at 12:35, Ard Biesheuvel wrote: On 9 September 2015 at 11:53, Heyi Guo wrote: During page entry attribute update, if there are table entries between starting BlockEntry and LastBlockEntry, table entries will be set as block e

Re: [edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 12:35, Ard Biesheuvel wrote: > On 9 September 2015 at 11:53, Heyi Guo wrote: >> During page entry attribute update, if there are table entries >> between starting BlockEntry and LastBlockEntry, table entries will be >> set as block entries and the allocated memory of the ta

Re: [edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Ard Biesheuvel
On 9 September 2015 at 11:53, Heyi Guo wrote: > During page entry attribute update, if there are table entries > between starting BlockEntry and LastBlockEntry, table entries will be > set as block entries and the allocated memory of the tables will be > leaked. > > so we break the inner loop when

[edk2] [PATCH v2 5/5] ArmPkg/Mmu: Fix potential page table memory leak

2015-09-09 Thread Heyi Guo
During page entry attribute update, if there are table entries between starting BlockEntry and LastBlockEntry, table entries will be set as block entries and the allocated memory of the tables will be leaked. so we break the inner loop when we find a table entry and run outer loop again to step in