Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-05 Thread Ryan Harkin
On 5 April 2016 at 11:18, Haojian Zhuang wrote: > On 5 April 2016 at 17:49, Ryan Harkin wrote: >> On 5 April 2016 at 09:37, Ryan Harkin wrote: >>> On 5 April 2016 at 03:57, Haojian Zhuang wrote: On 5 April 2016 at 01:17, Ryan Harkin wrote: > Hi Haojian, > > I've had time to in

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-05 Thread Haojian Zhuang
On 5 April 2016 at 17:49, Ryan Harkin wrote: > On 5 April 2016 at 09:37, Ryan Harkin wrote: >> On 5 April 2016 at 03:57, Haojian Zhuang wrote: >>> On 5 April 2016 at 01:17, Ryan Harkin wrote: Hi Haojian, I've had time to investigate where TC2 is hanging with your patches app

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-05 Thread Ryan Harkin
On 5 April 2016 at 09:37, Ryan Harkin wrote: > On 5 April 2016 at 03:57, Haojian Zhuang wrote: >> On 5 April 2016 at 01:17, Ryan Harkin wrote: >>> Hi Haojian, >>> >>> I've had time to investigate where TC2 is hanging with your patches >>> applied and narrowed it down to the single line of code m

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-05 Thread Ryan Harkin
On 5 April 2016 at 03:57, Haojian Zhuang wrote: > On 5 April 2016 at 01:17, Ryan Harkin wrote: >> Hi Haojian, >> >> I've had time to investigate where TC2 is hanging with your patches >> applied and narrowed it down to the single line of code marked below. >> >> I'm going to read the code now and

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Tian, Feng
/9] MmcDxe: set iospeed and bus width in SD stack On 5 April 2016 at 11:25, Tian, Feng wrote: > Hi, HaoJian > > We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host > controller follows SD PCI host controller spec, the whole stack should work. > > But looks like PL1

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Haojian Zhuang
On 5 April 2016 at 11:25, Tian, Feng wrote: > Hi, HaoJian > > We newly added EDKII SD/MMC stack to EDKII repo. If the SD/MMC host > controller follows SD PCI host controller spec, the whole stack should work. > > But looks like PL180 doesn't follow the SD PCI host controller spec, you > would ha

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Tian, Feng
arkin ; edk2-devel@lists.01.org; Leif Lindholm Subject: Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack On 5 April 2016 at 02:54, Ard Biesheuvel wrote: > On 4 April 2016 at 19:17, Ryan Harkin wrote: >> Hi Haojian, >> >> I've had time to investigate

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Haojian Zhuang
On 5 April 2016 at 02:54, Ard Biesheuvel wrote: > On 4 April 2016 at 19:17, Ryan Harkin wrote: >> Hi Haojian, >> >> I've had time to investigate where TC2 is hanging with your patches >> applied and narrowed it down to the single line of code marked below. >> >> I'm going to read the code now and

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Haojian Zhuang
On 5 April 2016 at 01:17, Ryan Harkin wrote: > Hi Haojian, > > I've had time to investigate where TC2 is hanging with your patches > applied and narrowed it down to the single line of code marked below. > > I'm going to read the code now and see if I can work out what it's > trying to do, but I th

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Ard Biesheuvel
On 4 April 2016 at 19:17, Ryan Harkin wrote: > Hi Haojian, > > I've had time to investigate where TC2 is hanging with your patches > applied and narrowed it down to the single line of code marked below. > > I'm going to read the code now and see if I can work out what it's > trying to do, but I th

Re: [edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-04-04 Thread Ryan Harkin
Hi Haojian, I've had time to investigate where TC2 is hanging with your patches applied and narrowed it down to the single line of code marked below. I'm going to read the code now and see if I can work out what it's trying to do, but I thought I'd tell you sooner because you might have a better

[edk2] [PATCH v2 8/9] MmcDxe: set iospeed and bus width in SD stack

2016-03-22 Thread Haojian Zhuang
Add more SD commands to support 4-bit bus width & iospeed. It's not formal code. And it needs to be updated later. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- EmbeddedPkg/Include/Protocol/MmcHost.h | 3 + EmbeddedPkg/Universal/MmcDxe/Mmc.