Yes, they are legacy version with old style alignment.
It's first try to address this return status change in this new API. We may
update some APIs depending on requirement and impacts evaluations later.
Best Regards & Thanks,
LONG, Qin
-Original Message-
From: Zhang, Chao B
Sent:
Qin:
What about other X509 related interface, such as X509GetTBSCert,
X509GetSubjectName. They all return TRUE/FALSE.
It looks inconsistent between these interfaces
-Original Message-
From: Long, Qin
Sent: Thursday, September 21, 2017 10:48 AM
To: ler...@redhat.com; Ye, Ting
On 09/21/17 05:50, Ye, Ting wrote:
> Hi Qin,
>
> I think we might add OPTIONAL attribute to CommonName, as NULL is an valid
> input for this API.
> In function description, I think we need update below statement to "if ***
> and *CommonNameSize is 0."
>
> "If CommonName is not NULL and
Hi Qin,
I think we might add OPTIONAL attribute to CommonName, as NULL is an valid
input for this API.
In function description, I think we need update below statement to "if *** and
*CommonNameSize is 0."
"If CommonName is not NULL and CommonNameSize is 0."
Others are good to me.
v3: Add extra CommonNameSize check since OpenSSL didn't check this
input parameter. (One openssl issue was filed to address this risk:
https://github.com/openssl/openssl/issues/4392)
v2: Update function interface to return RETURN_STATUS to represent
different error cases.
Add one new
5 matches
Mail list logo