Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-28 Thread Long, Qin
Yes, they are legacy version with old style alignment. It's first try to address this return status change in this new API. We may update some APIs depending on requirement and impacts evaluations later. Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent:

Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-28 Thread Zhang, Chao B
Qin: What about other X509 related interface, such as X509GetTBSCert, X509GetSubjectName. They all return TRUE/FALSE. It looks inconsistent between these interfaces -Original Message- From: Long, Qin Sent: Thursday, September 21, 2017 10:48 AM To: ler...@redhat.com; Ye, Ting

Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-22 Thread Laszlo Ersek
On 09/21/17 05:50, Ye, Ting wrote: > Hi Qin, > > I think we might add OPTIONAL attribute to CommonName, as NULL is an valid > input for this API. > In function description, I think we need update below statement to "if *** > and *CommonNameSize is 0." > > "If CommonName is not NULL and

Re: [edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-20 Thread Ye, Ting
Hi Qin, I think we might add OPTIONAL attribute to CommonName, as NULL is an valid input for this API. In function description, I think we need update below statement to "if *** and *CommonNameSize is 0." "If CommonName is not NULL and CommonNameSize is 0." Others are good to me.

[edk2] [PATCH v3] CryptoPkg: Add new API to retrieve commonName of X.509 certificate

2017-09-20 Thread Qin Long
v3: Add extra CommonNameSize check since OpenSSL didn't check this input parameter. (One openssl issue was filed to address this risk: https://github.com/openssl/openssl/issues/4392) v2: Update function interface to return RETURN_STATUS to represent different error cases. Add one new