For me, the hard-code string looks good to me here. I'm also fine if you stick
to move in UNI file.
Thanks,
Jiaxin
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, October 9, 2017 10:09 AM
> To: Wu, Jiaxin ; Meenakshi Aggarwal
> ; Carsey, Jaben ;
> edk2-devel@lists.01.org
> Subje
Do you need to put all the hard-code string in UNI file for localization?
Thanks/Ray
> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, October 9, 2017 9:29 AM
> To: Meenakshi Aggarwal ; Carsey, Jaben
> ; edk2-devel@lists.01.org; Ni, Ruiyu
>
> Subject: RE: [PATCH v3] Ifconfig : Fixe
I agree with Jaben. If NetLibDetectMedia return error status, we can output as
below:
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
(STR_IFCONFIG_INFO_MEDIA_STATE), gShellNetwork1HiiHandle, L"Media state
unknown");
Thanks,
Jiaxin
> -Original Message-
> From: Meenakshi Aggarwal [ma
It is hard to say when can an API fail because its dependent on implementation.
> -Original Message-
> From: Carsey, Jaben [mailto:jaben.car...@intel.com]
> Sent: Friday, October 06, 2017 7:32 PM
> To: Meenakshi Aggarwal ; edk2-
> de...@lists.01.org; Wu, Jiaxin ; Ni, Ruiyu
>
> Subject: R
Reviewed-by: Jaben Carsey
Do you know under what conditions the API will fail? Is it worth saying
something like media stats unknown when the function fails?
Ray,
What do you think?
> -Original Message-
> From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com]
> Sent: Thursday, O
Corrected commit message
Meenakshi Aggarwal (1):
Ifconfig : Fixed False information about Media State.
ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
--
2.7.4
___
edk2-dev
Issue : We were setting MediaPresent as TRUE (default) and
not checking return status of NetLibDetectMedia().
NetLibDetectMedia() sets MediaPresent FLAG in case of success
only and dont change flag on error.
So, Media State will display as 'Media Present', in case of
error also.
Fix : Check return
7 matches
Mail list logo
