Re: [edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

The function description comments should be not related to this patch. I am ok with or without updating the comments in this patch. Reviewed-by: Star Zeng . Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 8, 2018 7:06 PM To: Wang,

Re: [edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

On 08/08/18 09:04, Wang, Jian J wrote: > Hi Ruiyu, > > In function description comments, the @retval doesn't match the changes in > this patch. > > With those changes, > Reviewed-by: Jian J Wang Same from my side, Acked-by: Laszlo Ersek Thanks! Laszlo >> -Original Message- >>

Re: [edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

Hi Ruiyu, In function description comments, the @retval doesn't match the changes in this patch. With those changes, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 08, 2018 1:28 PM > To: edk2-devel@lists.01.org > Cc: Zeng,

[edk2] [PATCH v3] IntelFrameworkModulePkg/Csm: Set CSM memory executable

Commit b22a62be5cdc8fd19d87ec1ecfa5b28fb9be50ad * IntelFrameworkModule/LegacyBios:Use reserved memory for legacy data allocates reserved memory for holding legacy code/data. But with PcdDxeNxMemoryProtectionPolicy set to certain value to forbid execution when code is in certain type of memory,