Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Yao, Jiewen
.org; leif.lindh...@linaro.org; Yao, Jiewen; Gao, Liming; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/23/16 17:47, Ard Biesheuvel wrote: > On 23 February 2016 at 17:06, Laszlo Ersek wrote: > [supersnip]

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
On 02/23/16 17:47, Ard Biesheuvel wrote: > On 23 February 2016 at 17:06, Laszlo Ersek wrote: > [supersnip] >> By that I don't mean *another* new PCD, beyond the ACPI version PCD that >> Ard's patch series already contains -- I mean a more generic PCD that >> *replaces* the ACPI version PCD, and co

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Ard Biesheuvel
On 23 February 2016 at 17:06, Laszlo Ersek wrote: [supersnip] > By that I don't mean *another* new PCD, beyond the ACPI version PCD that > Ard's patch series already contains -- I mean a more generic PCD that > *replaces* the ACPI version PCD, and controls the allocations across all > drivers. >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
On 02/23/16 16:09, Yao, Jiewen wrote: > Ok, thanks for clarification. > > > > I just answer the last question below: > > -How does the Conclusion follow from Premises 1 through 4? What > guarantees it? > > > > - Premise 1: > OVMF installs memory that is >= 4GB as an untested memory

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Yao, Jiewen
Yao, Jiewen; Ard Biesheuvel Cc: Ni, Ruiyu; Tian, Feng; graeme.greg...@linaro.org; Justen, Jordan L; edk2-de...@ml01.01.org; leif.lindh...@linaro.org; Gao, Liming; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/23/1

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
modules, I think it is quite natural to >>> reckon with some additional customization and maintenance. >>> >>> For example, I would think the following library instances present >>> some additional maintenance burden too: >>> >>&

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
-- it does. I do question your claim that the burden is unnecessary. > > I've put insane amounts of work into OVMF's S3. If someone submits > bisectable, regression-conscious patches for OVMF that adapt OVMF to the > proposed repurposing of PcdDxeIplSwitchToLongMode,

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Yao, Jiewen
; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/23/16 14:27, Ard Biesheuvel wrote: > On 23 February 2016 at 13:58, Laszlo Ersek wrote: >> On 02/23/16 11:42, Yao, Jiewen wrote: >>> Laszl

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
D presents new maintenance burden >> -- it does. I do question your claim that the burden is unnecessary. >> >> I've put insane amounts of work into OVMF's S3. If someone submits >> bisectable, regression-conscious patches for OVMF that adapt OVMF to the >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Yao, Jiewen
; Gao, Liming; Fan, Jeff; Zeng, Star Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/23/16 11:42, Yao, Jiewen wrote: > Laszlo > > I do not understand why you only set 4G page table for X64 PEI. Two reasons. * First, OVMF

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Ard Biesheuvel
gMode, I will do my best to > test and review those patches. If no such patches will be submitted, I > will continue NACKing the repurposing of PcdDxeIplSwitchToLongMode. > > (Obviously, I'm also open to arguments that prove me wrong.) > > Thanks > Laszlo > >> >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
some functionality that is publicly available from > GenericBdsLib (and is used by PlatformBdsLib instances) needs to be > exported from the new boot manager library. > > Thanks > Laszlo > >> >> >> >> Thank you >> >> Yao Jiewen >

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Yao, Jiewen
; leif.lindh...@linaro.org; graeme.greg...@linaro.org; Fan, Jeff; Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/23/16 05:31, Yao, Jiewen wrote: > I discussed with Module owner. Below is summary for MdeModulePkg: > &g

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-23 Thread Laszlo Ersek
Biesheuvel [mailto:ard.biesheu...@linaro.org] > *Sent:* Monday, February 22, 2016 8:43 PM > *To:* Yao, Jiewen > *Cc:* Ni, Ruiyu; Laszlo Ersek; edk2-de...@ml01.01.org; Tian, Feng; Zeng, > Star; leif.lindh...@linaro.org; graeme.greg...@linaro.org; Fan, Jeff; > Gao, Liming > *Subject

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Yao, Jiewen
; Ard Biesheuvel Cc: Ni, Ruiyu; Tian, Feng; graeme.greg...@linaro.org; edk2-de...@ml01.01.org; leif.lindh...@linaro.org; Gao, Liming; Laszlo Ersek; Fan, Jeff Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 2016/2/23 12:31, Yao, Jiewen wrote

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Zeng, Star
Fan, Jeff; Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 22 February 2016 at 13:40, Yao, Jiewen wrote: I did a search on current MdeModulePkg. I found there are more modules allocating Below4G memory. Besides BD

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Yao, Jiewen
Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, February 22, 2016 8:43 PM To: Yao, Jiewen Cc: Ni, Ruiyu; Laszlo Ersek; edk2-de...@ml01.01.org; Tian, Feng; Zeng, Star; leif.lindh...@linaro.org; graeme.greg...@linaro.org; Fan, Jeff; Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModuleP

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
On 22 February 2016 at 13:42, Ard Biesheuvel wrote: > On 22 February 2016 at 13:40, Yao, Jiewen wrote: >> I did a search on current MdeModulePkg. I found there are more modules >> allocating Below4G memory. >> >> Besides BDS, we have BootGraphicsResourceTableDxe, BootScriptExecutorDxe, >> Firmwar

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
On 22 February 2016 at 13:40, Yao, Jiewen wrote: > I did a search on current MdeModulePkg. I found there are more modules > allocating Below4G memory. > > Besides BDS, we have BootGraphicsResourceTableDxe, BootScriptExecutorDxe, > FirmwarePerformanceDataTableDxe, PiDxeS3BootScriptLib, CapsuleRunti

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Yao, Jiewen
ailto:edk2-de...@ml01.01.org>; Tian, Feng; Zeng, Star; leif.lindh...@linaro.org<mailto:leif.lindh...@linaro.org>; graeme.greg...@linaro.org<mailto:graeme.greg...@linaro.org>; Fan, Jeff; Yao, Jiewen Cc: Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe:

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
On 22 February 2016 at 13:11, Laszlo Ersek wrote: > On 02/22/16 12:45, Ard Biesheuvel wrote: >> On 22 February 2016 at 11:24, Laszlo Ersek wrote: >>> On 02/22/16 04:35, Ni, Ruiyu wrote: Ard, So the final decision between you and Jiewen is a new PCD is still needed? If so, could you

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Laszlo Ersek
Laszlo > >>> >>> From: edk2-devel [edk2-devel-boun...@lists.01.org] on behalf of Laszlo >>> Ersek [ler...@redhat.com] >>> Sent: Friday, February 19, 2016 21:40 >>> To: Ard Biesheuvel; edk2-de...@ml01.01.org; T

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Ard Biesheuvel
n behalf of Laszlo Ersek >> [ler...@redhat.com] >> Sent: Friday, February 19, 2016 21:40 >> To: Ard Biesheuvel; edk2-de...@ml01.01.org; Tian, Feng; Zeng, Star; >> leif.lindh...@linaro.org; graeme.greg...@linaro.org; Fan, Jeff; Yao, Jiewen >> Cc: Gao, Liming >>

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-22 Thread Laszlo Ersek
redhat.com] > Sent: Friday, February 19, 2016 21:40 > To: Ard Biesheuvel; edk2-de...@ml01.01.org; Tian, Feng; Zeng, Star; > leif.lindh...@linaro.org; graeme.greg...@linaro.org; Fan, Jeff; Yao, Jiewen > Cc: Gao, Liming > Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe:

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-21 Thread Ni, Ruiyu
raeme.greg...@linaro.org; Fan, Jeff; Yao, Jiewen Cc: Gao, Liming Subject: Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed On 02/19/16 14:15, Ard Biesheuvel wrote: > The reserved region for storing performance data is allocated below 4 GB, > so t

Re: [edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-19 Thread Laszlo Ersek
On 02/19/16 14:15, Ard Biesheuvel wrote: > The reserved region for storing performance data is allocated below 4 GB, > so that its contents are accessible from PEI upon S3 resume. However, this > is a X64 pecularity, and on AARCH64 systems, which does not have this > restriction (nor does it have S

[edk2] [PATCH v3 2/4] IntelFrameworkModulePkg: BdsDxe: only allocate below 4 GB if needed

2016-02-19 Thread Ard Biesheuvel
The reserved region for storing performance data is allocated below 4 GB, so that its contents are accessible from PEI upon S3 resume. However, this is a X64 pecularity, and on AARCH64 systems, which does not have this restriction (nor does it have S3, btw), this limit may cause the allocation to f