Re: [edk2] [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal

2017-11-29 Thread Ard Biesheuvel
On 29 November 2017 at 08:28, Ni, Ruiyu wrote: > Ard, > PcdShellLibAutoInitialize is specially set to FALSE in old code for Shell.efi > build. > But in old code line 507, it is set FALSE for Shell.efi build. > So the global setting of this PCD can be removed. > OK, fair

Re: [edk2] [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal

2017-11-29 Thread Ni, Ruiyu
Ard, PcdShellLibAutoInitialize is specially set to FALSE in old code for Shell.efi build. But in old code line 507, it is set FALSE for Shell.efi build. So the global setting of this PCD can be removed. Thanks/Ray > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal

2017-11-28 Thread Ard Biesheuvel
On 29 November 2017 at 00:59, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- >

[edk2] [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal

2017-11-28 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Leif Lindholm Cc: Ard Biesheuvel --- BeagleBoardPkg/BeagleBoardPkg.dsc | 16 +--- BeagleBoardPkg/BeagleBoardPkg.fdf | 3 ++-