Re: [edk2] [PATCH v4 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

2017-12-07 Thread Wang, Jian J
Sure. I'll move them to VirtualMemory.h. If no more other comments, I think there's no need of a v5 patch. Thanks. Regards, Jian > -Original Message- > From: Zeng, Star > Sent: Friday, December 08, 2017 11:04 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric

Re: [edk2] [PATCH v4 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

2017-12-07 Thread Zeng, Star
Could EnablePageTableProtection and AllocatePageTableMemory just be declared in VirtualMemory.h but not DxeIpl.h? As their implementation are in VirtualMemory.c that is only used by X64 and IA32, but not other archs, DxeIpl.h is used by all archs. Also have same comments to ClearFirst4KPage and

[edk2] [PATCH v4 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

2017-12-07 Thread Jian J Wang
> v4: > a. Fix a calculation error in pool page number during initialization > b. Change comments to remove constants in description > v3: >Remove the public definition of PAGE_TABLE_POOL_HEADER but keep similar >concept locally. CpuDxe has its own page table pool. > v2: >Introduce pa