Re: [edk2] [PATCH v4 2/7] MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions

Good catch. "EFI" should be removed and "IN" should be "OUT". Thanks for the feedback. > -Original Message- > From: Zeng, Star > Sent: Thursday, November 09, 2017 1:13 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Yao,

Re: [edk2] [PATCH v4 2/7] MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions

Suggest to use " SMM Memory Attribute Protocol " instead of " EFI SMM Memory Attribute Protocol " in the comments. Should "+ IN UINT64 *Attributes" be "+ OUT UINT64 *Attributes" for EDKII_SMM_GET_MEMORY_ATTRIBUTES? Thanks, Star

[edk2] [PATCH v4 2/7] MdeModulePkg/SmmMemoryAttribute.h: Add new protocol definitions

The new protocol gEdkiiSmmMemoryAttributeProtocolGuid is intended for PiSmmCore to be able to change memory page attributes for the sake of heap guard feature. This protocol provides three interfaces to get/set/clear page attribute. struct _EDKII_SMM_MEMORY_ATTRIBUTE_PROTOCOL {