Re: [edk2] [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-31 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, January 31, 2019 3:37 PM > To: edk2-devel@lists.01.org > Cc: Mike Turner ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode() > > From:

Re: [edk2] [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-30 Thread Ni, Ray
Even ECC doesn't complain, I still suggest to change Encoding_table/Decoding_table to a proper name, e.g.: EncodingTable/DecodingTable. With the rename applied in V5 patch, Reviewed-by: Ray Ni ___ edk2-devel mailing list edk2-devel@lists.01.org

[edk2] [PATCH v5] MdePkg/BaseLib: Add Base64Encode() and Base64Decode()

2019-01-30 Thread Shenglei Zhang
From: Mike Turner Introduce public functions Base64Encode and Base64Decode. https://bugzilla.tianocore.org/show_bug.cgi?id=1370 v2:1.Remove some white space. 2.Add unit test with test vectors in RFC 4648. https://github.com/shenglei10/edk2/tree/encode_test