Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-14 Thread Leif Lindholm
On Sun, Oct 14, 2018 at 02:51:06PM +, Gao, Liming wrote: > Leif: > OK. I will move this patch set to edk2 staging repo for people > verification. Thats sounds like a good idea. > I will use git revert command to revert total 27 patches one by > one. Then, there will be 27 commit for

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-14 Thread Gao, Liming
Leif: OK. I will move this patch set to edk2 staging repo for people verification. I will use git revert command to revert total 27 patches one by one. Then, there will be 27 commit for the revert patches. Or, one commit to combine all revert patches. One commit is enough. Do you agree it?

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-14 Thread Laszlo Ersek
On 10/13/18 22:40, Leif Lindholm wrote: > Hi Yonghong, > > Please revert this patch. The broken state of the master branch must > be undone, not hacked on until individual bits seem to work. > > Plese do no further work on the master branch until the contents of > the tree is identical to what

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Leif Lindholm
Hi Yonghong, Please revert this patch. The broken state of the master branch must be undone, not hacked on until individual bits seem to work. Plese do no further work on the master branch until the contents of the tree is identical to what it was at 301402fa4797ac3a141e575329ca2ea91756414c. (I

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Zhu, Yonghong
Hi Ard, Thanks. I pushed this patch since it is critical block issue. Version SHA-1: 678f85131238622e576705117e299d81cff755c9 Best Regards, Zhu Yonghong -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Sunday, October 14, 2018 12:44 AM To: Zhu, Yonghong

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Sunday, October 14, 2018 12:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools/Tests: Update GNUmakef

Re: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Ard Biesheuvel
On 13 October 2018 at 18:40, Yonghong Zhu wrote: > Cover the case use do make -C BaseTools before run the .edksetup.sh > file. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu Reviewed-by: Ard Biesheuvel

[edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable

2018-10-13 Thread Yonghong Zhu
Cover the case use do make -C BaseTools before run the .edksetup.sh file. Cc: Ard Biesheuvel Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git