subject:"\[edk2\] \[Patch\] MdeModulePkg\: Fix SNP.Initialize\(\) spec conformance issue"

Re: [edk2] [Patch] MdeModulePkg: Fix SNP.Initialize() spec conformance issue

2016-05-26 Thread Wu, Jiaxin

Thanks Ting, version2 patch will be sent out later. After that, I will highlight it with your comments again. Thanks. Jiaxin > -Original Message- > From: Ye, Ting > Sent: Thursday, May 26, 2016 2:52 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Fu, Siyuan

Re: [edk2] [Patch] MdeModulePkg: Fix SNP.Initialize() spec conformance issue

2016-05-26 Thread Ye, Ting

Jiaxin, It looks to me the three places of below code can be merged together. Please double check. +Snp->Mode.State = EfiSimpleNetworkInitialized; +Status = EFI_SUCCESS; Also, I would like to highlight that the patch might bring interoperability issues to the NIC

[edk2] [Patch] MdeModulePkg: Fix SNP.Initialize() spec conformance issue

2016-05-25 Thread Jiaxin Wu

Current SNP UNDI Initialize command does not follow the UEFI Spec to update the SNP MediaPresent field. The result for the Initialize command execution check should be: StatFlags: (1) Monitor the upper two bits (14 & 15) in the field to know whether the command has been executed by the UNDI (Not