Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Wang, Sunny (HPS SW)
: RE: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile Importance: High Sunny: Yes. This is the replacement of Eric patch. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wang, S

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Gao, Liming
01.org > Cc: Ni, Ruiyu ; Dong, Eric > Subject: Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore > BootManagerMenuApp from LoadFile > > Hi Liming, > Except Ray's comment, others Look good to me. > Reviewed-by: Sunny Wang > > Hi Ray and Eric, > It looks l

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Wang, Sunny (HPS SW)
k2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile BootManagerMenuApp boot option is handled by EfiBootManagerGetBootManagerMenu. Don't need to handle it again when parse LoadFile protocol. Cc: Ruiyu Ni Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Gao, Liming
Ok. Got your comments. This patch just ignores BootManagerMenu from LoadFile. Next patch will rename BootMenuApp to BootManagerMenu. I will update them. Thanks Liming > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, September 01, 2016 10:02 AM > To: Gao, Liming ; edk2-devel@lists

Re: [edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Ni, Ruiyu
Liming, Please use the term "BootManagerMenu" instead of "BootMenuApp", to avoid confusion when reading from future developers. // Ignore BootMenuApp. its boot option will be created by BmRegisterBootManagerMenu(). --> // Ignore BootManagerMenu, which will be auto-created by EfiBootManagerGetBo

[edk2] [Patch] MdeModulePkg UefiBootManagerLib: Ignore BootManagerMenuApp from LoadFile

2016-08-31 Thread Liming Gao
BootManagerMenuApp boot option is handled by EfiBootManagerGetBootManagerMenu. Don't need to handle it again when parse LoadFile protocol. Cc: Ruiyu Ni Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Library/UefiBootManagerLib/Bm