Reviewed-by: Fu Siyuan <siyuan...@intel.com>

-----Original Message-----
From: Wu, Jiaxin 
Sent: Tuesday, September 8, 2015 9:41 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>
Subject: [Patch] NetworkPkg: Fix suspicious dereference of pointer 'FieldCount'

This patch is used to fix suspicious dereference of pointer 'FieldCount'
before NULL check.

Cc: Ye Ting <ting...@intel.com>
Cc: Fu Siyuan <siyuan...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
---
 NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c 
b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c
index 8c29f20..a83c963 100644
--- a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c
+++ b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesProtocol.c
@@ -305,11 +305,10 @@ HttpUtilitiesParse (
   CHAR8                     *FieldValue;
   UINTN                     Index;
   
   Status          = EFI_SUCCESS;
   TempHttpMessage = NULL;
-  *FieldCount     = 0;
   Token           = NULL;
   NextToken       = NULL;
   FieldName       = NULL;
   FieldValue      = NULL;
   Index           = 0;
@@ -326,10 +325,11 @@ HttpUtilitiesParse (
   CopyMem (TempHttpMessage, HttpMessage, HttpMessageSize);
   
   //
   // Get header number
   //
+  *FieldCount = 0;
   Token = TempHttpMessage;
   while (TRUE) {
     FieldName     = NULL;
     FieldValue    = NULL;
     NextToken = GetFieldNameAndValue (Token, &FieldName, &FieldValue);
-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to