Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Dong, Eric
@lists.01.org > Cc: Crystal Lee <crystal...@ami.com.tw> > Subject: RE: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & > Bsp. > > With the subject change suggested by Laszlo, Reviewed-by: Ruiyu Ni > <ruiyu...@intel.com> > > Thanks/Ray > >

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Ni, Ruiyu
el@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Crystal Lee <crystal...@ami.com.tw> > Subject: Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & > Bsp. > > On 10/19/17 04:42, Eric Dong wrote: > > MicrocodeDetect function

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-19 Thread Laszlo Ersek
On 10/19/17 04:42, Eric Dong wrote: > MicrocodeDetect function will run by every threads, and it will > use PcdGet to get PcdCpuMicrocodePatchAddress and > PcdCpuMicrocodePatchRegionSize, if change both PCD default to dynamic, > system will in non-deterministic behavior. > > By design, UEFI/PI

[edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

2017-10-18 Thread Eric Dong
MicrocodeDetect function will run by every threads, and it will use PcdGet to get PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize, if change both PCD default to dynamic, system will in non-deterministic behavior. By design, UEFI/PI services are single threaded and not re-entrant so