: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from
MtrrSetAllMtrrs()
On 07/13/2016 11:19 AM, Laszlo Ersek wrote:
> On 07/13/16 17:46, Kinney, Michael D wrote:
>> Laszlo,
>>
>> I agree that the DEBUG() messages for this are very valuable to debug
>> MTRR ca
On 07/13/2016 11:19 AM, Laszlo Ersek wrote:
On 07/13/16 17:46, Kinney, Michael D wrote:
Laszlo,
I agree that the DEBUG() messages for this are very valuable to debug
MTRR cache settings.
Another option is to add logic to detect if the calling CPU is the BSP or
not and only invoke DEBUG() macro
l01.01.org
>> Cc: Kinney, Michael D ; Tian, Feng
>>
>> Subject: Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from
>> MtrrSetAllMtrrs()
>>
>> On 07/13/16 10:27, Fan, Jeff wrote:
>>> Laszlo,
>>>
>>> Yes. You are correct. MtrrSetA
On 07/13/16 17:46, Kinney, Michael D wrote:
> Laszlo,
>
> I agree that the DEBUG() messages for this are very valuable to debug
> MTRR cache settings.
>
> Another option is to add logic to detect if the calling CPU is the BSP or
> not and only invoke DEBUG() macros if the caller is the BSP. Tha
nal Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, July 13, 2016 5:00 AM
> To: Fan, Jeff ; edk2-de...@ml01.01.org
> Cc: Kinney, Michael D ; Tian, Feng
>
> Subject: Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from
> MtrrSetAllMtrrs(
Laszlo,
I agree that the DEBUG() messages for this are very valuable to debug
MTRR cache settings.
Another option is to add logic to detect if the calling CPU is the BSP or
not and only invoke DEBUG() macros if the caller is the BSP. That would
not require any changes to the MtrrLib APIs or ca
aszlo
> Ersek
> Sent: Wednesday, July 13, 2016 2:21 PM
> To: Fan, Jeff; edk2-de...@ml01.01.org
> Cc: Kinney, Michael D; Tian, Feng
> Subject: Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from
> MtrrSetAllMtrrs()
>
> On 07/13/16 02:33, Jeff Fan wrote:
>&g
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Remove MTRRs display from
MtrrSetAllMtrrs()
On 07/13/16 02:33, Jeff Fan wrote:
> MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's
> MTRR setting should be displayed if EFI_D_C
On 07/13/16 08:20, Laszlo Ersek wrote:
> - Audit all current uses of MtrrSetAllMtrrs(), and wherever it is
> obviously called from the BSP, append the following explicit code:
>
> DEBUG_CODE (MtrrDebugPrintAllMtrrs());
Sorry, that should be
DEBUG_CODE (MtrrDebugPrintAllMtrrs ());
(whites
On 07/13/16 02:33, Jeff Fan wrote:
> MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's MTRR
> setting should be displayed if EFI_D_CACHE flag is set when MTRR updated. In
> MtrrSetAllMtrrs(), it's not necessary to display MTRR setting again due to the
> MTRR settings should be
MtrrSetAllMtrrs() maybe used by APs to sync BSP's MTRR settings. BSP's MTRR
setting should be displayed if EFI_D_CACHE flag is set when MTRR updated. In
MtrrSetAllMtrrs(), it's not necessary to display MTRR setting again due to the
MTRR settings should be always same among BSP/APs. This updating co
11 matches
Mail list logo
