Re: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage.

2017-08-15 Thread Kinney, Michael D
Hi Eric, I think we should keep the Getxxx() functions to make the code easier to read and we have matched Get/Set functions to access these PCDs. Mike > -Original Message- > From: Dong, Eric > Sent: Tuesday, August 15, 2017 6:04 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Shao, M

[edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage.

2017-08-15 Thread Eric Dong
Current code allocate buffer for the pointer which later get value from PCD database. but current code error use "=" for this case. Use AllocateCopyPool instead to fix it. V2 enhanced to directly use AllocateCopyPool to get the PCD value. V3 enhanced to avoid using local temp variable. Cc: Ruiyu

Re: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage.

2017-08-14 Thread Ni, Ruiyu
ml01.01.org > Subject: [edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer > pointer error usage. > > Current code allocate buffer for the pointer which later get value from PCD > database. but current code error use "=" for this case. > Use CopyMem inste

[edk2] [Patch] UefiCpuPkg RegisterCpuFeaturesLib: Fix buffer pointer error usage.

2017-08-14 Thread Eric Dong
Current code allocate buffer for the pointer which later get value from PCD database. but current code error use "=" for this case. Use CopyMem instead to fix it. Cc: Ruiyu Ni Cc: Shao, Ming Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library