Re: [edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-15 Thread Subramanian, Sriram (System FW, HP Servers)
Reviewed-by: Sriram Subramanian -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, October 15, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: ting...@intel.com; Subramanian, Sriram (System FW, HP Servers) Subject: [Patch 2/2] MdeModulePkg: reset DHCP child whe

Re: [edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-14 Thread Fu, Siyuan
Thanks Ting, I will update the words when commit the patch. -Original Message- From: Ye, Ting Sent: Thursday, October 15, 2015 2:27 PM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: srira...@hpe.com Subject: RE: [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile. Suggest

Re: [edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-14 Thread Ye, Ting
Suggest to update the comments below: Other functionality of PXE Base Code protocol will not be stopped, when downloading is successfully. This is confusing since although we stopped DHCP instance when downloading is successfully in this patch, The PXEBC protocol still capable of providing full

[edk2] [Patch 2/2] MdeModulePkg: reset DHCP child when leaving PXE LoadFile.

2015-10-14 Thread Fu Siyuan
The DHCP4 can have only one configured child instance so we need to reset the DHCP4 child when leaving PXE driver's LoadFile() function, otherwise the other programs which also need to use DHCP4 (like HTTP boot) will be impacted. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-b