Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

, Jiaxin Subject: RE: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it. Sriram, You are right, I missed this case. Will correct it when commit the patch, thanks. Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beh

Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

0:55 PM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before > use it. > > Hi Siyuan, > > For the below case: > > + > + if (Packet->TotalSize < sizeof (DNS_HEAD

Re: [edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

Hi Siyuan, For the below case: + + if (Packet->TotalSize < sizeof (DNS_HEADER)) { +goto ON_EXIT; + } We may also need to handle the case of TotalSize == sizeof (HEADER), which indicates the payload for these packets is 0. For example in the code that follows the above check: RcvString

[edk2] [Patch 2/2] NetworkPkg: Check received packet size before use it.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Cc: Subramanian Sriram --- NetworkPkg/Dhcp6Dxe/Dhcp6Io.c | 6 +- NetworkPkg/DnsDxe/DnsImpl.c | 18 +++--- NetworkPkg/TcpDxe/TcpInput.c | 13 - NetworkPkg/U