Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-19 Thread Laszlo Ersek
On 05/19/16 04:27, Ni, Ruiyu wrote: > Laszlo, > > My understanding is: you have concern why I only call > GetCenturyRtcAddress() in RTC driver’s entry point, but > don’t write the century value to CMOS. > Is my understanding correct? > > Because RTC’s entry point calls PcRtcInit(), which calls >

Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-18 Thread Ni, Ruiyu
Laszlo, My understanding is: you have concern why I only call GetCenturyRtcAddress() in RTC driver's entry point, but don't write the century value to CMOS. Is my understanding correct? Because RTC's entry point calls PcRtcInit(), which calls PcRtcSetTime(), which writes the century value to

Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-18 Thread Laszlo Ersek
On 05/18/16 07:20, Ruiyu Ni wrote: > When ACPI table is installed before PcRtc driver runs, > the ACPI table installation callback isn't called which causes the > century value isn't written to the CMOS. > The patch calls GetCenturyRtcAddress() in entry point to fix > the bug. > >

[edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-17 Thread Ruiyu Ni
When ACPI table is installed before PcRtc driver runs, the ACPI table installation callback isn't called which causes the century value isn't written to the CMOS. The patch calls GetCenturyRtcAddress() in entry point to fix the bug. Contributed-under: TianoCore Contribution Agreement 1.0