.01.org
> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>
> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
> AP initialization logic.
>
> On 10/25/2017 08:13 PM, Dong, Eric wrote:
> > Laszlo,
> >
> >
&g
<ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>
Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
AP initialization logic.
Hi Eric,
On 10/25/17 07:42, Dong, Eric wrote:
Hi Laszlo,
I think I have clear about your raised issues for Ovmf platform. In this c
.com>; Paolo Bonzini <pbonz...@redhat.com>
> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
> AP initialization logic.
>
> Hi Eric,
>
> On 10/25/17 07:42, Dong, Eric wrote:
> > Hi Laszlo,
> >
> > I think I have clear about
Hi Eric,
On 10/25/17 07:42, Dong, Eric wrote:
> Hi Laszlo,
>
> I think I have clear about your raised issues for Ovmf platform. In this
> case, I think your platform not suit for this code change. How about I do
> below change based on the new code:
>
> - if (CpuMpData->CpuCount == 0) {
ni <pbonz...@redhat.com>;
> Jeff Fan <vanjeff_...@hotmail.com>
> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
> AP initialization logic.
>
> Hi Eric,
>
> On 10/24/17 17:23, Dong, Eric wrote:
> > Laszlo,
> >
> >> -O
Ruiyu <ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>
Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
AP initialization logic.
CC Paolo
On 10/23/17 09:22, Eric Dong wrote:
diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc
b/UefiCpuPkg/Libr
Ruiyu <ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>
>> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
>> AP initialization logic.
>>
>> CC Paolo
>>
>> On 10/23/17 09:22, Eric Dong wrote:
>>> diff --
vel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Paolo Bonzini <pbonz...@redhat.com>
> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
> AP initialization logic.
>
> Laszlo,
>
> > -Original Message-
> > From: Laszlo
> Subject: Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for
> AP initialization logic.
>
> CC Paolo
>
> On 10/23/17 09:22, Eric Dong wrote:
> > Current logic always waiting for a specific value to collect all APs
> > count. This logic may ca
CC Paolo
On 10/23/17 09:22, Eric Dong wrote:
> Current logic always waiting for a specific value to collect all APs
> count. This logic may caused some platforms cost too much time to
> wait for time out.
> This patch add new logic to collect APs count. It adds new variable
> NumApsExecuting to
latile type. It may not be necessary
> to add volatile for NumApsExecuting.
>
> Jeff
>
> 发件人: Ni, Ruiyu<mailto:ruiyu...@intel.com>
> 发送时间: 2017年10月24日 14:03
> 收件人: Dong, Eric<mailto:eric.d...@intel.com>; edk2-
> de...@lists.01.org<mailto:edk2-devel@lists.01.or
You need to have "volatile" for "UINTN NumApsExecuting;".
Otherwise, compiler may optimize the code to cause below code wait forever:
while (CpuMpData->MpCpuExchangeInfo->NumApsExecuting != 0) {
CpuPause();
}
Thanks/Ray
> -Original Message-
> From: Dong, Eric
>
Current logic always waiting for a specific value to collect all APs
count. This logic may caused some platforms cost too much time to
wait for time out.
This patch add new logic to collect APs count. It adds new variable
NumApsExecuting to detect whether all APs have finished initialization.
Each
13 matches
Mail list logo
