Re: [edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode

, Jordan L; Tian, Feng Subject: Re: [edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode Mike, I agree with your suggestion. I will update the patch. I have received another request to add one PCD to specify the C-State value instead of the max C-State always. Thus

Re: [edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode

Mike, I agree with your suggestion. I will update the patch. I have received another request to add one PCD to specify the C-State value instead of the max C-State always. Thus, platform could decide the C-state by the balance the performance and power. + ## Specifies the AP target C-state fo

Re: [edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode

Jeff, I recommend a small change to GetApLoopMode(). 1) Make sure PcdCpuApLoopMode is set to a valid value 2) Only check if CPU supports MONITOR/MWAIT if PcdCpuApLoopMode is set to ApInMwaitLoop. Here is a proposal for the updated logic: = ApLoopMode =

[edk2] [Patch 2/6] UefiCpuPkg/CpuMpPei: Add GetApLoopMode() to get AP loop mode

Add GetApLoopMode() that will get PCD PcdCpuApLoopMode firstly. If it is ApInMwaitLoop, we will check if MONITOR/MWAIT feature supported by CPUID. If MONITOR/MWAIT feature is not supported, force AP loop mode to ApInHltLoop. GetApLoopMode() also return the maximum C-state supported by processor an