Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, August 3, 2017 5:32 PM
> To: edk2-devel@lists.01.org
> Cc: Fan, Jeff ; Ni, Ruiyu ; Kinney,
> Michael D
>
I agree.
Thanks/Ray
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 4, 2017 12:53 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Fan, Jeff ; Kinney, Michael D
>
> Subject: RE: [Patch 4/7] QuarkSocPkg
Ray,
I check the spec, found the Quark definition has some small difference with
normal MSR. So I prefer not do this change for Quark.
Thanks,
Eric
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, August 3, 2017 6:22 PM
To: Dong, Eric ; edk2-devel@lists.01.org
Eric,
Please refer to the below code sample to avoid defining local macros.
MSR_IA32_MTRR_DEF_TYPE_REGISTER DefType;
//
// Enable Cache MTRR
//
DefType.Uint64 = AsmReadMsr64 (MSR_IA32_MTRR_DEF_TYPE);
DefType.Bits.E = 1;
DefType.Bits.FE = 1;
AsmWriteMsr64 (MSR_IA32_MTRR_DEF_TYPE,
Cc: Jeff Fan
Cc: Ruiyu Ni
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
.../QuarkNorthCluster/Library/MtrrLib/MtrrLib.c| 26
5 matches
Mail list logo