Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-10-20 Thread Jordan Justen
edk2/commits/framebuffer-blt-lib-v2 -Jordan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan > Justen > Sent: Wednesday, October 21, 2015 8:57 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch 6/

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-10-20 Thread Ni, Ruiyu
devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Wednesday, October 21, 2015 8:57 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API Ray, I've been thinking about this a bit. For the BltLi

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-10-20 Thread Jordan Justen
Ray, I've been thinking about this a bit. For the BltLib, I think you mainly like the FrameBufferBltLib library instance. So, how about just design the library interface just for this purpose, and call the interface FrameBufferBltLib rather than BltLib? What do you think of these 3 patches? http

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-26 Thread Laszlo Ersek
On 08/24/15 08:15, Ni, Ruiyu wrote: > Jordan, > The mail is too long so let me summarize in below: (I changed all > API name to remove "Lib") > 1. Have four or six BLT APIs? > four: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo > six: BltVideoFill BltVideoToVideo BltVideoToBuf

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Ni, Ruiyu
Jordan, The mail is too long so let me summarize in below: (I changed all API name to remove "Lib") 1. Have four or six BLT APIs? four: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo six: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo BltVideoToBufferEx

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
On 2015-08-23 20:09:23, Ni, Ruiyu wrote: > Jordan, > reply embedded in the mail. > > Mike, > Jordan proposed to add a new parameter Configuration in BltConfigure, > instead of removing this API, to eliminate the global variables in > library implementation. I think it's also a good solution and

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Ni, Ruiyu
Jordan, reply embedded in the mail. Mike, Jordan proposed to add a new parameter Configuration in BltConfigure, instead of removing this API, to eliminate the global variables in library implementation. I think it's also a good solution and can benefit the library performance. What's your thou

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
On 2015-08-17 19:42:04, Ni, Ruiyu wrote: > Jordan, > Sorry I missed your previous questions. Let me try to answer all > your questions in this email. > > Q1: Why merging Ex and non-Ex APIs? Providing Non-Ex APIs was to > make simpler functions available for blt operations. > > Merging the Ex and

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Ni, Ruiyu
Jordan, Sorry I missed your previous questions. Let me try to answer all your questions in this email. Q1: Why merging Ex and non-Ex APIs? Providing Non-Ex APIs was to make simpler functions available for blt operations. Merging the Ex and non-EX APIs is to avoid the library APIs provide overlapp

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Jordan Justen
On 2015-08-17 06:45:27, Ruiyu Ni wrote: > The BltConfigure() API caches the video frame buffer meta data which > forbids the library to be implemented to support re-entry. How does this help? GraphicsOutputDxe will set a mode, and then use BltLib with that mode. I already asked this, and I had so

[edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Ruiyu Ni
The BltConfigure() API caches the video frame buffer meta data which forbids the library to be implemented to support re-entry. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Laszlo Ersek Cc: Jordan Justen --- .../Application/BltLibSample/BltLibSample.c