Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-03 Thread Fan, Jeff
Eric, Typo: " Protected Processor Inventory Number" should be " Intel Processor Trace " + @param[in] StateIf TRUE, then the Protected Processor Inventory + Number feature must be enabled. + If FALSE, then the Protected

Re: [edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-03 Thread Fan, Jeff
Eric, In ProcTraceInitialize(), we cannot assume ProcessorNumber 0 is always BSP. + if (ProcessorNumber == 0) { +IsBsp = TRUE; The recommended method is to allocate memory in ProcTraceGetConfigData(). Or add one buffer point in ConfigData structure. If buffer point is NULL, allocate

[edk2] [Patch v3 3/3] UefiCpuPkg: Enable Processor Trace feature.

2017-08-01 Thread Eric Dong
Cc: Jeff Fan Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- .../CpuCommonFeaturesLib/CpuCommonFeatures.h | 66 +++ .../CpuCommonFeaturesLib/CpuCommonFeaturesLib.c| 11 +