nks/Ray
>
>> -Original Message-
>> From: edk2-devel On Behalf Of Ni, Ruiyu
>> Sent: Monday, August 13, 2018 1:39 PM
>> To: Dong, Eric ; Laszlo Ersek ;
>> edk2-devel@lists.01.org
>> Subject: Re: [edk2] [Patch v3 3/5] UefiCpuPkg/CpuS3DataDxe: Change
Ni, Ruiyu
> Sent: Monday, August 13, 2018 1:39 PM
> To: Dong, Eric ; Laszlo Ersek ;
> edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch v3 3/5] UefiCpuPkg/CpuS3DataDxe: Change
> Memory Type and address limitation.
>
> Eric,
> I think you could change:
> AcpiCpuDataEx
Eric,
I think you could change:
AcpiCpuDataEx = AllocateBootServiceMemory (sizeof (ACPI_CPU_DATA_EX));
->
AcpiCpuDataEx = AllocatePages (EFI_SIZE_TO_PAGES (sizeof (ACPI_CPU_DATA_EX)));
So the AllocateBootServiceMemory() is not needed.
Thanks/Ray
> -Original Message-
> From: Dong, Eric
>
Hi Laszlo,
I checked the code base and don't find the API AllocateZeroPages (), and I
agree to Zero the memory before using it. So I think update the original
function is the best way now.
Thanks,
Eric
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturda
On 08/10/18 18:12, Laszlo Ersek wrote:
> On 08/10/18 06:19, Eric Dong wrote:
>> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
>> the memory type no need to be ACPI NVS type, also the address not
>> limit to below 4G.
>>
>> This change remove the limit of ACPI NVS memory ty
On 08/10/18 06:19, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
> the memory type no need to be ACPI NVS type, also the address not
> limit to below 4G.
>
> This change remove the limit of ACPI NVS memory type and below 4G.
>
> Pass OS boot and resume
Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
the memory type no need to be ACPI NVS type, also the address not
limit to below 4G.
This change remove the limit of ACPI NVS memory type and below 4G.
Pass OS boot and resume from S3 test.
Cc: Marvin Häuser
Cc: Fan Jeff
C
7 matches
Mail list logo
