Re: [edk2] [Patch v5 21/24] OvmfPkg/PlatformBootManagerLib: Fix gcc-4.8 Ia32 build failure

2016-05-03 Thread Laszlo Ersek
On 05/03/16 07:35, Ruiyu Ni wrote: > The Width and Height assignment suppresses an invalid gcc-4.8 warning > on Ia32. > These warnings look unjustified to me. Namely, near the beginning of > the function, there is a while(1) loop. In that loop, > ConvertBmpToGopBlt() is called unconditionally. If t

[edk2] [Patch v5 21/24] OvmfPkg/PlatformBootManagerLib: Fix gcc-4.8 Ia32 build failure

2016-05-02 Thread Ruiyu Ni
The Width and Height assignment suppresses an invalid gcc-4.8 warning on Ia32. These warnings look unjustified to me. Namely, near the beginning of the function, there is a while(1) loop. In that loop, ConvertBmpToGopBlt() is called unconditionally. If the call fails, the rest of the loop body is n