[edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-06 Thread Heyi Guo
When UEFI receives IPMP echo packets it will enter Ip4IcmpReplyEcho function, and then call Ip4Output. However, if Ip4Output gets some error and exits early, e.g. fails to find the route entry, memory buffer of "Data" gets no chance to be freed and memory leak will be caused. If there is such an at

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-06 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Thursday, December 7, 2017 10:22 AM > To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org > Cc: Heyi Guo ; Junbiao Hong ; > Zeng, Star ; Dong, Eric ; Ni, > Ruiyu ; Fu, Siyuan ; Wu, Jiax

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-06 Thread Wu, Jiaxin
It's is good to me. Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Thursday, December 7, 2017 10:22 AM > To: linaro-u...@lists.linaro.org; edk2-devel@lists.01.org > Cc: Heyi Guo ; Junbiao Hong > ; Zeng, Star ; Dong, Eri

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-07 Thread Heyi Guo
Hi Siyuan and Jiaxin, Thanks for your review; shall I generate a formal patch and post it again, as well as making some commit message refinement? Regards, Gary (Heyi Guo) 在 12/7/2017 3:01 PM, Wu, Jiaxin 写道: It's is good to me. Reviewed-by: Jiaxin Wu Thanks, Jiaxin -Original Mes

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-07 Thread Wu, Jiaxin
Hi Gary, Agree to generate a formal patch. You can attach the reviewed-by tag at the same time. Can you help to file one Bugzilla for this issue? BTW, Do you need us commit the patch or by yourself? Thanks, Jiaxin > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Se

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-07 Thread Guo Heyi
On Fri, Dec 08, 2017 at 12:39:30AM +, Wu, Jiaxin wrote: > Hi Gary, > > Agree to generate a formal patch. You can attach the reviewed-by tag at the > same time. > > Can you help to file one Bugzilla for this issue? No Problem. > > BTW, Do you need us commit the patch or by yourself? Yes,

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-07 Thread Guo Heyi
Hi Jiaxin, We are still having our QA to finally verify the patches (including the ICMP error listener bug fix), so I will post the formal patch after regression test completes. Regards, Gary (Heyi Guo) On Fri, Dec 08, 2017 at 10:04:20AM +0800, Guo Heyi wrote: > On Fri, Dec 08, 2017 at 12:39

Re: [edk2] [RFC] MdeModulePkg/Ip4Dxe: fix ICMP echo reply memory leak

2017-12-11 Thread Guo Heyi
Hi Jiaxin, Bug 812 has been created: https://bugzilla.tianocore.org/show_bug.cgi?id=812 The regression test has been completed on our platform and I'll post a formal patch in minutes. Regards, Gary (Heyi Guo) On Fri, Dec 08, 2017 at 02:00:05PM +0800, Guo Heyi wrote: > Hi Jiaxin, > > We are st