Re: [edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-06-04 Thread Kinney, Michael D
Jiewen, Good suggestion. I will add then in next version. Mike > -Original Message- > From: Yao, Jiewen > Sent: Monday, June 4, 2018 4:09 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Sean Brogan > Subject: RE: [RFC v3 2/4] FmpDevicePkg: Add library > instances > > Look

Re: [edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-06-04 Thread Yao, Jiewen
Looks good. Can we add "Is" before the function - LowestSupportedVersionCheckRequired (), LockFmpDeviceAtLockEventGuidRequired () ? That is IsLowestSupportedVersionCheckRequired (), IsLockFmpDeviceAtLockEventGuidRequired (). Thank you Yao Jiewen > -Original Message- > From: Kinney, Mi

[edk2] [RFC v3 2/4] FmpDevicePkg: Add library instances

2018-05-29 Thread Michael D Kinney
From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib, and FmpPayloadHeaderLib.