Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test

2018-12-13 Thread Jin, Eric
Hello Supreeth, I use "Apply Patch Serial" operation provided by TortoiseGit to do the applying. The operation is equivalent to "git.exe am --3way --ignore-space-change --keep-cr Fix.patch" What is your command to apply patch? I observe the same failure with "git.exe am Fix.patch" and "--ignor

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test

2018-12-12 Thread Supreeth Venkatesh
Eric, Nothing wrong with code. However, when applying this patch with git am, I encounter the below errors. (not sure if it is related to mailbox configuration). Not sure if it is my mailbox, could you please test it on your side using git am and let me know? git am ./patches/0001_SctPkg\:Corr

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test

2018-12-12 Thread Leif Lindholm
Hi Eric, On Wed, Dec 12, 2018 at 11:32:14AM +0800, Eric Jin wrote: > Name macros appropriately to follow the rule > in coding standards specification. > Change the following macro from variable style > HwErrRecVariableNameLength > HwErrRecVariableNamePrefixLength > HwErrRecVariableNameIndexLength

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test

2018-12-11 Thread Eric Jin
Name macros appropriately to follow the rule in coding standards specification. Change the following macro from variable style HwErrRecVariableNameLength HwErrRecVariableNamePrefixLength HwErrRecVariableNameIndexLength to macro style. HW_ERR_REC_VARIABLE_NAME_LEN HW_ERR_REC_VARIABLE_NAME_PREFIX_LEN