Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Patch is good to me. Please also update the copyright year when commit it. Reviewed-by: Siyuan Fu -Original Message- From: Zhang, Lubo Sent: Thursday, January 21, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

I will update the copyright year when I commit it, thanks. -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:26 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin Subject: RE: [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Hi, Lubo Pls ignore my previous mail. I just checked UEFI spec, it didn't mentioned the GroupTable, RouteTable and IcmpTypeList should be freed by caller. So I think we shouldn't make this change. Siyuan -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:26 AM To:

[edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin