Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-22 Thread Subramanian, Sriram (EG Servers Platform SW)
Reviewed-by: Sriram Subramanian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, August 19, 2016 1:23 PM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ; Wu Jiaxin Subject: [edk2] [patch] MdeModulePkg:Fix bug in

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-22 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Friday, August 19, 2016 3:53 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin ; Hegde Nagaraj P Subject: [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4. If a FQDN contains 3 dots '.' like "a.

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-22 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Lubo > Sent: Friday, August 19, 2016 3:53 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin ; Hegde Nagaraj P > Subject: [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4. > > If a FQDN contains 3

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-19 Thread Hegde, Nagaraj P
Cosmetic comment: if (!NET_IS_DIGIT(*Ip4Str)) { ^ Add a space here Reviewed-by: Hegde Nagaraj P -Original Message- From: Zhang Lubo [mailto:lubo.zh...@intel.com] Sent: Friday, August 19, 2016 1:23 PM To: edk2-devel@lists.01.org Cc: Fu Siyuan ;

[edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

2016-08-19 Thread Zhang Lubo
If a FQDN contains 3 dots '.' like "a.b.c.com", the AsciiStrToIp4 will return success as the HostName has a valid IP address. So we need to check if it is a decimal character before using AsciiStrDecimalToUintn. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: