Thank you for your comments, I will correct the error in next patch.
-Original Message-
From: Fu, Siyuan
Sent: Wednesday, January 27, 2016 4:44 PM
To: Zhang, Lubo; edk2-devel@lists.01.org
Cc: Ye, Ting; Wu, Jiaxin
Subject: RE: [patch] NetworkPkg: change HTTP API typos.
Hi, Lubo
I have 2
Hi, Lubo
I have 2 comments as below:
1. The " HttpConfigData != NULL " is redundant in below code.
+ // Check input parameters.
+ //
+ if (This == NULL ||
+ HttpConfigData == NULL ||
+ (HttpConfigData != NULL && ((HttpConfigData->LocalAddressIsIPv6 &&
HttpConfigData->AccessPoint.IPv6N
Got it, thanks
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, January 27, 2016 3:44 PM
To: Zhang, Lubo; edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting
Subject: RE: [patch] NetworkPkg: change HTTP API typos.
Lubo,
You also need to update the corresponding copyright year.
Othe
Lubo,
You also need to update the corresponding copyright year.
Others look good to me.
Reviewed-by: Jiaxin Wu
Thanks.
Jiaxin
-Original Message-
From: Zhang, Lubo
Sent: Tuesday, January 26, 2016 5:27 PM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting; Wu, Jiaxin
Subject: [patch
change HTTP API typos and clarify returned status code in HTTP API.
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo
---
NetworkPkg/HttpDxe/HttpImpl.c | 47 ---
NetworkPkg/HttpDxe/
5 matches
Mail list logo