Re: [edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-21 Thread Fu, Siyuan
Hi, Lubo Some comments as below: 1. Dhcp6Dxe,DnsDxe\ComponentName.c HttpBootDxe\HttpBootDhcp6.c UefiPxeBcDxe\PxeBcDhcp6.c Check for NULL pointer before free it. 2. DnsDxe\DnsImpl.c Ip6Dxe\ComponentName.c Mtftp6Dxe\Mtftp6Support.c There is memory leak if GetModeData return SUCCESS

Re: [edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-21 Thread Zhang, Lubo
Thank you for your comments, I will make a new patch to fix the issue. -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:45 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin Subject: RE: [patch] NetworkPkg:Fix Network memory leak when calling

[edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

2016-01-20 Thread Zhang Lubo
Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin