Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Wednesday, August 31, 2016 1:27 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [edk2] [patch] Sh

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Bi, Dandan > Sent: Wednesday, August 31, 2016 6:09 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: RE: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "b

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Bi, Dandan
rsey, Jaben Subject: RE: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command Should we check for too few also? What if the user sends 2 params? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Carsey, Jaben
, Jaben > Subject: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" > command > Importance: High > > When user uses the command "bcfg driver|boot [dump [-v]]", > the number of command line value parameters (doesn't include

Re: [edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-31 Thread Shah, Tapan
Reviewed-by: Tapan Shah -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 31, 2016 12:27 AM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Jaben Carsey Subject: [edk2] [patch] ShellPkg: Add check for "dump"

[edk2] [patch] ShellPkg: Add check for "dump" parameter in "bcfg" command

2016-08-30 Thread Dandan Bi
When user uses the command "bcfg driver|boot [dump [-v]]", the number of command line value parameters (doesn't include the flag) must be three. We can add this point to check whether using this command correctly. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement