Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Bi, Dandan
To: Kinney, Michael D <michael.d.kin...@intel.com>; Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com> Subject: Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx" On 04/12/18 18:47, Kinney, M

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Laszlo Ersek
com>; edk2- >> de...@lists.01.org >> Cc: Dong, Eric <eric.d...@intel.com> >> Subject: Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: >> Add "extern" keyword for "gPatchxxx" >> >> Hello Dandan, >> >> On 04/12/18 10:50, Dandan Bi

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Kinney, Michael D
de...@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com> > Subject: Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: > Add "extern" keyword for "gPatchxxx" > > Hello Dandan, > > On 04/12/18 10:50, Dandan Bi wrote: > > Background descripti

Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Laszlo Ersek
Hello Dandan, On 04/12/18 10:50, Dandan Bi wrote: > Background description: > In SmmProfileInternal.h, ECC check tool report an issue at line 103. > Detailed ECC Error info:Variable definition appears in header file. > Include files should contain only public or only private data and > cannot

[edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

2018-04-12 Thread Dandan Bi
Background description: In SmmProfileInternal.h, ECC check tool report an issue at line 103. Detailed ECC Error info:Variable definition appears in header file. Include files should contain only public or only private data and cannot contain code or define data variables ECC report similar issues