[edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-22 Thread Jiewen Yao
According to the spec, each entry in the Memory Attributes table shall have the same type as the region it was carved out of in the UEFI memory map. The current attribute uses RTData for PE Data, but it should be RTCode. This patch fixed the issue. It is validated with or without PropertiesTable.

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Yao, Jiewen Sent: Tuesday, February 23, 2016 12:47 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen ; Ard Biesheuvel ; Gao, Liming Subject: [patch V3] MdeModulePkg: Fix Memory Attributes table type issue According to the spec, each entry i

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-23 Thread Yao, Jiewen
Hi Ard Liming gave me minor update comment, and I have finished V3. Should I wait for your validation on AArch64? Thank you Yao Jiewen -Original Message- From: Gao, Liming Sent: Tuesday, February 23, 2016 1:10 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Ard Biesheuvel Subject: RE: [p

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-24 Thread Ard Biesheuvel
On 24 February 2016 at 07:02, Yao, Jiewen wrote: > Hi Ard > Liming gave me minor update comment, and I have finished V3. > > Should I wait for your validation on AArch64? > Still works fine for me. Thanks. Tested-by: Ard Biesheuvel > -Original Message- > From: Gao, Liming > Sent: Tuesd

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-02-24 Thread Yao, Jiewen
Thank you very much! From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, February 24, 2016 4:15 PM To: Yao, Jiewen Cc: Gao, Liming; edk2-de...@ml01.01.org Subject: Re: [patch V3] MdeModulePkg: Fix Memory Attributes table type issue On 24 February 2016 at 07:02, Yao, Jiewen wr

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
On 23 February 2016 at 05:46, Jiewen Yao wrote: > According to the spec, each entry in the Memory > Attributes table shall have the same type as > the region it was carved out of in the UEFI memory map. > The current attribute uses RTData for PE Data, but > it should be RTCode. > > This patch fixe

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Yao, Jiewen
t; Ard Biesheuvel > Sent: Thursday, March 31, 2016 4:37 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org ; Gao, Liming > > Subject: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > On 23 February 2016 at 05:46, Jiewen Yao wrote: >

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Yao, Jiewen
ct: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > Hi Ard > I think you replied mail say this patch works fine at Wednesday, February 24, > 2016 4:15 PM. > > May I know if this is new issue or old issue? > > > Also, in order to narrow

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Yao, Jiewen
> From: Yao, Jiewen > Sent: Thursday, March 31, 2016 4:51 PM > To: Yao, Jiewen ; Ard Biesheuvel > > Cc: edk2-devel@lists.01.org ; Gao, Liming > > Subject: RE: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > BTW: I found below 2 ent

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 10:48, Yao, Jiewen wrote: > Hi Ard > I think you replied mail say this patch works fine at Wednesday, February 24, > 2016 4:15 PM. > > May I know if this is new issue or old issue? > This is a new issue. > > Also, in order to narrow down issue, would you please send me more

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
h 31, 2016 4:51 PM >> To: Yao, Jiewen ; Ard Biesheuvel >> >> Cc: edk2-devel@lists.01.org ; Gao, Liming >> >> Subject: RE: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table >> type issue >> >> BTW: I found below 2 entries are m

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
gt; >> Would you please check where these 2 RT_data regions are allocated? >> >> >> >>> -Original Message- >>> From: Yao, Jiewen >>> Sent: Thursday, March 31, 2016 4:51 PM >>> To: Yao, Jiewen ; Ard Biesheuvel >>> >>&g

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
On 31 March 2016 at 15:20, Yao, Jiewen wrote: > Hi Ard > Thanks for your log. Yes, it seems new issue, I have never encountered before. > > Here is what I found: > > 1) MemoryAttributeTable is always installed in ReadyToBoot event. (Sorry, I > gave wrong info on EndOfDxe, that is for old properti

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Yao, Jiewen
; From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, March 31, 2016 9:34 PM > To: Yao, Jiewen > Cc: Gao, Liming ; edk2-devel@lists.01.org > > Subject: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > On 31 March 201

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Ard Biesheuvel
inal Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Thursday, March 31, 2016 9:34 PM >> To: Yao, Jiewen >> Cc: Gao, Liming ; edk2-devel@lists.01.org >> >> Subject: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-03-31 Thread Yao, Jiewen
t, it looks fine, but later when I process it, the first > entry is corrupted. > > Thanks for the help! > Ard. > > > >> -Original Message- > >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > >> Sent: Thursday, March 31, 2016 9:34 PM

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
On 31 March 2016 at 15:33, Ard Biesheuvel wrote: > On 31 March 2016 at 15:20, Yao, Jiewen wrote: >> Hi Ard >> Thanks for your log. Yes, it seems new issue, I have never encountered >> before. >> >> Here is what I found: >> >> 1) MemoryAttributeTable is always installed in ReadyToBoot event. (Sor

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
On 1 April 2016 at 09:24, Ard Biesheuvel wrote: > On 31 March 2016 at 15:33, Ard Biesheuvel wrote: >> On 31 March 2016 at 15:20, Yao, Jiewen wrote: >>> Hi Ard >>> Thanks for your log. Yes, it seems new issue, I have never encountered >>> before. >>> >>> Here is what I found: >>> >>> 1) MemoryAt

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
On 1 April 2016 at 09:25, Ard Biesheuvel wrote: > On 1 April 2016 at 09:24, Ard Biesheuvel wrote: >> On 31 March 2016 at 15:33, Ard Biesheuvel wrote: >>> On 31 March 2016 at 15:20, Yao, Jiewen wrote: Hi Ard Thanks for your log. Yes, it seems new issue, I have never encountered b

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
On 1 April 2016 at 14:16, Ard Biesheuvel wrote: > On 1 April 2016 at 09:25, Ard Biesheuvel wrote: >> On 1 April 2016 at 09:24, Ard Biesheuvel wrote: >>> On 31 March 2016 at 15:33, Ard Biesheuvel wrote: On 31 March 2016 at 15:20, Yao, Jiewen wrote: > Hi Ard > Thanks for your log. Y

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Yao, Jiewen
day, April 1, 2016 8:19 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org ; Gao, Liming > > Subject: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > On 1 April 2016 at 14:16, Ard Biesheuvel wrote: > > On 1 April 2016 at 09:25, Ard Biesheuv

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
-Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Ard Biesheuvel >> Sent: Friday, April 1, 2016 8:19 PM >> To: Yao, Jiewen >> Cc: edk2-devel@lists.01.org ; Gao, Liming >> >> Subject: Re: [edk2] [patch V3] MdeMo

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Yao, Jiewen
heuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, April 1, 2016 10:02 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org ; Gao, Liming > > Subject: Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table > type issue > > On 1 April 2016 at 15:57, Yao, Jiewen wrote: > >

Re: [edk2] [patch V3] MdeModulePkg: Fix Memory Attributes table type issue

2016-04-01 Thread Ard Biesheuvel
On 1 April 2016 at 16:07, Yao, Jiewen wrote: > That is enough. Thanks! > > I suggest you use this way as temp work-around. > > As final solution, I think we can construct table after all ReadyToBoot > events are processed, which need more update in DxeCore. > For now, the work around is fine. T