Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

2018-05-09 Thread Bi, Dandan
Dandan <dandan...@intel.com> Cc: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Gao, Liming <liming@intel.com> Subject: RE: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer Dandan, Can you describe the build failure met by Gary Lin in final com

Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

2018-05-09 Thread Ni, Ruiyu
Wednesday, May 9, 2018 4:20 PM > To: Bi, Dandan <dandan...@intel.com> > Cc: edk2-devel@lists.01.org; Dong, Eric <eric.d...@intel.com>; Gao, Liming > <liming@intel.com> > Subject: Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using > uninitialized point

Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

2018-05-09 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Wednesday, May 9, 2018 1:02 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; Gary Lin Subject: [patch v2] BaseTools/VfrCompile:

Re: [edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

2018-05-09 Thread Gary Lin
On Wed, May 09, 2018 at 01:02:11PM +0800, Dandan Bi wrote: > V2: > Add function _INIT_OPHDR_COND () for variable initialization. > Make code logic more clean. > > Previously _CLEAR_SAVED_OPHDR () is used for variable > initialization, and we updated it to clean memory. > But _CLEAR_SAVED_OPHDR ()

[edk2] [patch v2] BaseTools/VfrCompile: Avoid using uninitialized pointer

2018-05-08 Thread Dandan Bi
V2: Add function _INIT_OPHDR_COND () for variable initialization. Make code logic more clean. Previously _CLEAR_SAVED_OPHDR () is used for variable initialization, and we updated it to clean memory. But _CLEAR_SAVED_OPHDR () is still called for variable initialization. This will cause