Re: [edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

2018-02-27 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 27, 2018 9:47 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Gao, Liming ; > Kinney, Michael D > Subject: [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure > > v2: Add [

Re: [edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

2018-02-27 Thread Laszlo Ersek
On 02/27/18 02:47, Dandan Bi wrote: > v2: Add [LibraryClasses] section in INF file and refine coding style. > > There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. > XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul > XXX.lib(XXX.obj): error LNK2001: unresolv

[edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

2018-02-26 Thread Dandan Bi
v2: Add [LibraryClasses] section in INF file and refine coding style. There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allshl XXX.lib(XXX.obj):