Re: [edk2] Data Structure alignment

2019-03-14 Thread Tim Lewis
. Thanks, Tim -Original Message- From: edk2-devel On Behalf Of TVKR Sent: Thursday, March 14, 2019 1:47 PM To: edk2-devel@lists.01.org Subject: [edk2] Data Structure alignment Hi, The PCI FW spec says PCI Data Structure must be DWORD aligned and I came across this code the uses the following

[edk2] Data Structure alignment

2019-03-14 Thread TVKR
Hi, The PCI FW spec says PCI Data Structure must be DWORD aligned and I came across this code the uses the following check (RomHeader->PcirOffset & 3) != 0 The above is using the PcirOffset to do the check and not the actual data structure itself (located at RomHeader + RomHeader->PcirOffset) Sho