Since we've been discussing Phabricator for code reviews, I thought
people might be interested in an example of the emails it can be
configured to send. This one's from the FreeBSD project and its instance
at https://reviews.freebsd.org when I committed a changeset to the SVN repo.
This revision was automatically updated to reflect the committed changes.
Closed by commit rS339796: Simplify the EFI delay() function by calling
BS->Stall() (authored by bcran, committed by ).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D16753?vs=46794&id=49670#toc
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D16753?vs=46794&id=49670
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D16753/new/
REVISION DETAIL
https://reviews.freebsd.org/D16753
AFFECTED FILES
head/stand/efi/libefi/delay.c
CHANGE DETAILS
diff --git a/head/stand/efi/libefi/delay.c b/head/stand/efi/libefi/delay.c
--- a/head/stand/efi/libefi/delay.c
+++ b/head/stand/efi/libefi/delay.c
@@ -33,15 +33,5 @@
void
delay(int usecs)
{
- static EFI_EVENT ev = 0;
- UINTN junk;
-
- if (!ev) {
- if (BS->CreateEvent(EVT_TIMER, TPL_APPLICATION, 0, 0, &ev)
- != EFI_SUCCESS)
- return;
- }
-
- BS->SetTimer(ev, TimerRelative, usecs * 10);
- BS->WaitForEvent(1, &ev, &junk);
+ BS->Stall(usecs);
}
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: bcran, imp, kevans, manu, eadler
D16753.49670.patch
diff --git a/head/stand/efi/libefi/delay.c b/head/stand/efi/libefi/delay.c
--- a/head/stand/efi/libefi/delay.c
+++ b/head/stand/efi/libefi/delay.c
@@ -33,15 +33,5 @@
void
delay(int usecs)
{
- static EFI_EVENT ev = 0;
- UINTN junk;
-
- if (!ev) {
- if (BS->CreateEvent(EVT_TIMER, TPL_APPLICATION, 0, 0, &ev)
- != EFI_SUCCESS)
- return;
- }
-
- BS->SetTimer(ev, TimerRelative, usecs * 10);
- BS->WaitForEvent(1, &ev, &junk);
+ BS->Stall(usecs);
}
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
