Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

2018-11-22 Thread Laszlo Ersek
On 11/22/18 01:06, Bryan Rosario via edk2-devel wrote: > Hi all, > > I noticed that there is apparently a hardcoded B/D/F for an IDE Controller > in BdsPlatform.c, when setting bit 15 of a particular register: > https://github.com/tianocore/edk2/blob/14923c1a6bf9940b48feeaf47cb5d6c662b6528c/OvmfPk

Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

2018-11-21 Thread Bryan Rosario via edk2-devel
non-functional hardware features. > > > > Regards, > > -Ken. > > > > *From:* Bryan Rosario [mailto:b...@google.com] > *Sent:* Wednesday, November 21, 2018 5:29 PM > *To:* Ken Taylor > *Cc:* Alain Gefflaut; edk2-devel@lists.01.org > *Subject:* Re: [edk2] Hardco

Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

2018-11-21 Thread Ken Taylor
To: Ken Taylor Cc: Alain Gefflaut; edk2-devel@lists.01.org Subject: Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c? Hi Ken, That's what I had guessed -- thanks for confirming that it's platform specific. In my use case, I actually want the code to work on multipl

Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

2018-11-21 Thread Bryan Rosario via edk2-devel
t; From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Bryan Rosario via edk2-devel > Sent: Wednesday, November 21, 2018 4:07 PM > To: edk2-devel@lists.01.org > Cc: Alain Gefflaut > Subject: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c? > &g

[edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

2018-11-21 Thread Bryan Rosario via edk2-devel
Hi all, I noticed that there is apparently a hardcoded B/D/F for an IDE Controller in BdsPlatform.c, when setting bit 15 of a particular register: https://github.com/tianocore/edk2/blob/14923c1a6bf9940b48feeaf47cb5d6c662b6528c/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c#L1612-L1617 . Why